Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datahub]: Api form formats output #861

Merged
merged 19 commits into from
May 3, 2024
Merged

[Datahub]: Api form formats output #861

merged 19 commits into from
May 3, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Apr 22, 2024 •
edited
Loading

Description

This PR adds the output formats dynamically to the API form, with the use of the ogc-client lib.
It also adds more MIME formats to the formats parser.

The docker compo needs to be updated to test!

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited
Loading

Affected libs: ui-elements, feature-notifications, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search, util-shared, ui-widgets, ui-inputs, ui-layout, data-access-datafeeder, api-metadata-converter, api-repository, feature-auth, util-data-fetcher, data-access-gn4, util-app-config, common-fixtures, ui-map, common-domain, ui-dataviz, util-i18n,
Affected apps: metadata-editor, demo, datahub, webcomponents, map-viewer, search, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Apr 22, 2024 •
edited
Loading

Coverage Status

coverage: 84.177% (+0.02%) from 84.157%
when pulling 69ec149 on dh/api-form-list-formats
into bc5d77f on main.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited
Loading

📷 Screenshots are here!

@cmoinier cmoinier changed the title [Datahub]: [Datahub]: Api form formats output Apr 22, 2024
Angi-Kinas
Angi-Kinas reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmoinier. Just found small things. Otherwise LGTM 👍

apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts Outdated Show resolved Hide resolved
libs/ui/elements/src/lib/record-api-form/record-api-form.component.spec.ts Outdated Show resolved Hide resolved
jahow
jahow reviewed May 2, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cmoinier, I think this PR is good to go, thanks! There is a conflicting change on the dump, I hope it won't be too much trouble to reproduce the changes in the database. Please merge when this is rebased & green, thanks!

apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts Show resolved Hide resolved
@cmoinier cmoinier force-pushed the dh/api-form-list-formats branch from 10713b6 to 84f4209 Compare May 3, 2024 09:20
@cmoinier cmoinier merged commit 2b8cc03 into main May 3, 2024
9 checks passed
@cmoinier cmoinier deleted the dh/api-form-list-formats branch May 3, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angi-Kinas Angi-Kinas Angi-Kinas left review comments

@jahow jahow jahow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmoinier @coveralls @jahow @Angi-Kinas